fix(crypto): Fix crash loading older sender data from storage

[andybalaam]

Fixes #4424

[richvdh]

There are a whole bunch of other renames in #4067 that we need to check for; notably OwnUserIdentityVerifiedState (https://github.com/matrix-org/matrix-rust-sdk/pull/4067/files#diff-d28a9285dd9fd0d1ced29b1986dc92d7a754bb846a24cab48ec78073a1581166R874) which was the one that caused problems for Valere, but also VerificationLevel, and there may be others.

[andybalaam]

Sorry, was rushing to find a fix and missed the other places. Will expand this.

[poljar]

This talks about a crash, but we just changed the serialization format, deserialization failures should not result in crashes. So we need to also find where the crash happens and convert that to an error.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (0ca35d6) to head (385c0ab).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4425   +/-   ##
=======================================
  Coverage   85.39%   85.40%           
=======================================
  Files         283      283           
  Lines       31472    31472           
=======================================
+ Hits        26877    26880    +3     
+ Misses       4595     4592    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andybalaam]

This talks about a crash, but we just changed the serialization format, deserialization failures should not result in crashes. So we need to also find where the crash happens and convert that to an error.

It was a crash, right @BillCarsonFr ? Can you paste the stack trace?