-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(snapshot): Use snapshot testing in sdk-common #4428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
...napshots/matrix_sdk_common__deserialized_responses__tests__snapshot_test_algorithm_info.snap
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4428 +/- ##
==========================================
+ Coverage 85.41% 85.43% +0.01%
==========================================
Files 283 283
Lines 31559 31559
==========================================
+ Hits 26955 26961 +6
+ Misses 4604 4598 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for adding this.
d907b0f
to
3b31bbe
Compare
Tentative to introduce snapshot testing using insta.rs.
Added some initial doc on the Contributing.md file
As a draft now, because I have some open questions on how to do things.
I need also to see what to do for CI
export CI=true
Signed-off-by: