-
Notifications
You must be signed in to change notification settings - Fork 303
feat(wasm): Upgrade to uniffi 0.29.3 to support wasm targets #5189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5189 +/- ##
=======================================
Coverage 85.08% 85.09%
=======================================
Files 328 328
Lines 36877 36877
=======================================
+ Hits 31376 31379 +3
+ Misses 5501 5498 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
use uniffi_bindgen::BindgenCrateConfigSupplier; | ||
|
||
#[derive(Debug, Clone, Default)] | ||
pub struct CrateConfigSupplier { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have some docs. What does this config supplier do differently from the default upstream one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which upstream class one are you seeing? I only see the trait and an 'Empty' supplier in the 2.9.x versions of Uniffi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I had a seen a "default config supplier". There seem to be two upstream though: https://docs.rs/uniffi_bindgen/0.29.3/uniffi_bindgen/cargo_metadata/struct.CrateConfigSupplier.html is the other one.
What's the status of this PR? |
@Hywan this PR is still necessary, it upgrades us to the most recent uniffi (0.29.3) which contains support for Wasm targets. Without it the matrix-sdk-ffi crate will not compile. It is unfortunately blocked on the complement-crypto library, which I believe is blocked on NordSecurity considering an upgrade I submitted NordSecurity/uniffi-bindgen-go#77. I believe Matthew has asked someone to look into the complement-crypto issue, which I believe is currently monkey-patching to work with a very old version of uniffi. |
Upgrade to what will soon be uniffi 0.29.3 (release is planned for next week). This mostly concerns an upgrade of the xtask orchestration system, but there were some small changes to the .udl spec that were needed as well.
This will likely produce issues with the complement-crypto package, which seems to still be using uniffi 0.25 to build.
Signed-off-by: Daniel Salinas