Some cleanup #5267
Merged
Some cleanup #5267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was added in the very first commit for matrix-sdk-ffi and I have no recollection of what was meant there.
They are only semantically different if a macro of the same name exists,
in which case the foo::{self} import only imports foo-the-module, not
foo-the-macro.
Visual indentation was removed from rustfmt's style defaults in the 2024 edition of the style rules.
jplatte
requested review from
Hywan,
andybalaam and
poljar
and removed request for
a team and
Hywan
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #5267 +/- ##
==========================================
- Coverage 90.20% 90.18% -0.03%
==========================================
Files 334 334
Lines 104822 104822
Branches 104822 104822
==========================================
- Hits 94555 94534 -21
- Misses 6214 6236 +22
+ Partials 4053 4052 -1 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to the review feedback from #5255.
Signed-off-by: Jonas Platte