Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate /initialSync for peeking #2036

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

morguldir
Copy link
Contributor

@morguldir morguldir commented Dec 17, 2024

@morguldir morguldir requested a review from a team as a code owner December 17, 2024 19:39
@richvdh richvdh self-requested a review January 3, 2025 12:24
Co-authored-by: Richard van der Hoff <[email protected]>
Comment on lines 10 to 12
{{% boxes/note %}}
This api should now exclusively be used for "peeking" into publicly viewable rooms you're not a member of ([Room Previews](/client-server-api/#room-previews))
{{% /boxes/note %}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this {{% boxes %}} will work well with the playground. Better to just make a regular paragraph.

Get a copy of the current state and the most recent messages in a room.

This endpoint was deprecated in r0 of this specification. There is no
direct replacement; the relevant information is returned by the
Using this endpoint for something other than peeking was deprecated in r0 of this specification. \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we use this trailing-\ format anywhere else. Either make a new paragraph or continue the same one; don't try to sit on the fence with a line break.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it out, originally did it because it was soft wrapping in a really bad spot on my machine, can't reproduce now though

Co-authored-by: Richard van der Hoff <[email protected]
Signed-off-by: morguldir <[email protected]>
@richvdh richvdh self-requested a review January 14, 2025 14:37
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@richvdh richvdh merged commit e341525 into matrix-org:main Jan 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants