-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undeprecate /initialSync for peeking #2036
Conversation
Signed-off-by: morguldir <[email protected]>
…ent section Signed-off-by: morguldir <[email protected]>
Signed-off-by: morguldir <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
{{% boxes/note %}} | ||
This api should now exclusively be used for "peeking" into publicly viewable rooms you're not a member of ([Room Previews](/client-server-api/#room-previews)) | ||
{{% /boxes/note %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this {{% boxes %}}
will work well with the playground. Better to just make a regular paragraph.
Get a copy of the current state and the most recent messages in a room. | ||
|
||
This endpoint was deprecated in r0 of this specification. There is no | ||
direct replacement; the relevant information is returned by the | ||
Using this endpoint for something other than peeking was deprecated in r0 of this specification. \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we use this trailing-\
format anywhere else. Either make a new paragraph or continue the same one; don't try to sit on the fence with a line break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took it out, originally did it because it was soft wrapping in a really bad spot on my machine, can't reproduce now though
Co-authored-by: Richard van der Hoff <[email protected] Signed-off-by: morguldir <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In line with #214, see also https://matrix.to/#/!NasysSDfxKxZBzJJoE:matrix.org/$WlhuSb0FwAK_43eEv1x36mmr6L-JVbh3hoAr1Gq8u2k?via=matrix.org&via=envs.net&via=element.io
Pull Request Checklist
Preview: https://pr2036--matrix-spec-previews.netlify.app