Add some <meta name="description" ...> to pages (#214)

Not the best but probably better than the default (a good first iteration) Part of #202
matrix-org · May 5, 2023 · aeceb19 · aeceb19
1 parent b108845
commit aeceb19
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 1 deletion.
diff --git a/server/hydrogen-render/render-page-html.js b/server/hydrogen-render/render-page-html.js
@@ -17,6 +17,7 @@ function renderPageHtml({
   assert(vmRenderContext);
   assert(pageOptions);
   assert(pageOptions.title);
+  assert(pageOptions.description);
   assert(pageOptions.entryPoint);
   assert(pageOptions.cspNonce);
 
@@ -45,6 +46,7 @@ function renderPageHtml({
           <meta name="viewport" content="width=device-width, initial-scale=1">
           ${maybeNoIndexHtml}
           ${sanitizeHtml(`<title>${pageOptions.title}</title>`)}
+          ${sanitizeHtml(`<meta name="description" content="${pageOptions.description}">`)}
           <link rel="icon" href="${faviconMap.ico}" sizes="any">
           <link rel="icon" href="${faviconMap.svg}" type="image/svg+xml">
           ${styles

diff --git a/server/middleware/timeout-middleware.js b/server/middleware/timeout-middleware.js
@@ -83,6 +83,7 @@ async function timeoutMiddleware(req, res, next) {
 
     const pageOptions = {
       title: `Server timeout - Matrix Public Archive`,
+      description: `Unable to respond in time (${requestTimeoutMs / 1000}s)`,
       entryPoint: 'client/js/entry-client-timeout.js',
       locationHref: urlJoin(basePath, req.originalUrl),
       // We don't have a Matrix room so we don't know whether or not to index. Just choose

diff --git a/server/routes/client-side-room-alias-hash-redirect-route.js b/server/routes/client-side-room-alias-hash-redirect-route.js
@@ -15,6 +15,7 @@ assert(basePath);
 function clientSideRoomAliasHashRedirectRoute(req, res) {
   const pageOptions = {
     title: `Page not found - Matrix Public Archive`,
+    description: `This page does not exist but we may be able to redirect you to the right place.`,
     entryPoint: 'client/js/entry-client-room-alias-hash-redirect.js',
     locationHref: urlJoin(basePath, req.originalUrl),
     // We don't have a Matrix room so we don't know whether or not to index. Just choose
@@ -30,7 +31,7 @@ function clientSideRoomAliasHashRedirectRoute(req, res) {
         404: Page not found.
         <span class="js-try-redirect-message" style="display: none">One sec while we try to redirect you to the right place.</span>
       </h1>
-      <p>If there was a #room_alias:server hash in the URL, we tried redirecting  you to the right place.</p>
+      <p>If there was a #room_alias:server hash in the URL, we tried redirecting you to the right place.</p>
       <p>
         Otherwise, you're simply in a place that does not exist.
         You can ${sanitizeHtml(`<a href="${basePath}">go back to the homepage</a>.`)}

diff --git a/server/routes/room-directory-routes.js b/server/routes/room-directory-routes.js
@@ -75,6 +75,8 @@ router.get(
 
     const pageOptions = {
       title: `Matrix Public Archive`,
+      description:
+        'Browse thousands of rooms using Matrix. The new portal into the Matrix ecosystem.',
       entryPoint: 'client/js/entry-client-room-directory.js',
       locationHref: urlJoin(basePath, req.originalUrl),
       shouldIndex,

diff --git a/server/routes/room-routes.js b/server/routes/room-routes.js
@@ -898,6 +898,7 @@ router.get(
 
     const pageOptions = {
       title: `${roomData.name} - Matrix Public Archive`,
+      description: `View the history of ${roomData.name} in the Matrix Public Archive`,
       entryPoint: 'client/js/entry-client-hydrogen.js',
       locationHref: urlJoin(basePath, req.originalUrl),
       shouldIndex,