Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 18+ false positives with NSFW check #279

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Fix 18+ false positives with NSFW check #279

merged 1 commit into from
Jun 29, 2023

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Jun 29, 2023 •
edited
Loading

Fix 18+ false positives with NSFW check

Was noticing false positives with our test room names like: planet-1688081266353-room-18

Before:

/(\b|_)18+(\b|_)/i

After:

/(\b|_|-|\s|^)18\+(\b|_|-|\s|$)/i

Dev notes

https://www.debuggex.com/

npm run test -- --grep "checkTextForNsfw"

@MadLittleMods
Fix 18+ false positives with NSFW check
b7185c8 
Was noticing this with our test room names like: `planet-1688081266353-room-18`
@MadLittleMods MadLittleMods added the T-Defect Something isn't working. Bugs, crashes, or other reported issues. label Jun 29, 2023
@MadLittleMods MadLittleMods marked this pull request as ready for review June 29, 2023 23:55
@MadLittleMods MadLittleMods merged commit 59c9d31 into main Jun 29, 2023
MadLittleMods added a commit that referenced this pull request Jun 30, 2023
@MadLittleMods
Prepare changelog with #279
a26b852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
T-Defect Something isn't working. Bugs, crashes, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MadLittleMods