Distinguish room state and timeline events #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintown
force-pushed
the
push-state
branch
7 times, most recently
from
dc635a0 to
818269a
Compare
This was referenced Dec 6, 2024
Open
robintown
force-pushed
the
push-state
branch
from
818269a to
2d386ca
Compare
robintown
force-pushed
the
push-state
branch
from
2d386ca to
6c7da2a
Compare
robintown
force-pushed
the
push-state
branch
3 times, most recently
from
826365b to
a31991c
Compare
This is an implementation of an update to MSC2762, which provides a new action for informing widgets of changes to room state.
|
toger5
approved these changes
Jan 13, 2025
Comment on lines
+278
to
+283
| // If new events are allowed and the currently viewed room isn't covered | ||
| // by a timeline capability, then this is the widget's opportunity to | ||
| // learn the state of the viewed room | ||
| if (allowedEvents.length > 0 && this.viewedRoomId !== null && !this.canUseRoomTimeline(this.viewedRoomId)) { | ||
| this.pushRoomState(this.viewedRoomId); | ||
| } |
There was a problem hiding this comment.
I cannot follow this based on the comment. Shouldnt the widget never see any room if it does not have the timeline capability. Not event the viewed one? Or was that one of the widget api confusions. In that case it would be super helpful to provide that background here.
| `org.matrix.msc2762.timeline:${roomId}`, | ||
| `org.matrix.msc2762.receive.state_event:${type}`, | ||
| ]); | ||
| await loadIframe(['org.matrix.msc2762.receive.state_event:net.example.test#B']); |
There was a problem hiding this comment.
why do we remove the timeline capability here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of an update to MSC2762. See the description there for an explainer.