Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a New Post Checklist to PRs #1944

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a New Post Checklist to PRs #1944

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f454219
Add a New Post Checklist to PRs
MTRNord Jul 18, 2023
b9bf2db
Add a mention about existing author naming conventions and ensure the…
MTRNord Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!-- Thanks for submitting a PR! Please ensure the following requirements are met when writing a new post -->

## New Post Checklist

- [ ] Links are linkified
- [ ] Bare links are surrounded by `<>` (required since Zola follows commonmark strictly)
Copy link
Contributor

@jplatte jplatte Oct 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More like because pulldown_cmark doesn't support auto-detection of bare links (yet): pulldown-cmark/pulldown-cmark#695

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Well that's unfortunate. Reading the spec I thought this is actually intentional by the commonmark spec 😅

- [ ] Links with names are of the pattern `[Name](URL)`
- [ ] The frontmatter is valid
- [ ] `date` frontmatter contains a time with timezone (This ensures that posts are properly ordered in Feed Readers)
- [ ] A `category` and an `author` taxonomy are set
- [ ] Check at https://matrix.org/author/ for already existing author naming conventions to avoid duplicate authors
Loading