You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some more recent issues (#2278 , #2276 , #2261 and #2180 and probably others) have shown a pattern of things that may be possible to catch with testing. So I decided to get a stab at building a simple playwright based testsuite for this.
One thing to clear up is if we follow wcag2a or wcag2aa 🤔 (it can be configured)
My opinion is to go with aa since we want a partial redesign anyway. But if not its easy to change the tests to only run against a which should allow us to run all tests afaik without skipping.
Since we also just had the case that the frontpage failed due to the link in the new banner (which is also fixed by #2319 ) here is an example where we can find the html reports of these errors: https://github.com/matrix-org/matrix.org/actions/runs/8859887109?pr=2301 under artifacts there is a html-report--attempt-1 artifact which will contain a human readable format. Sadly I didnt find a nice way to have it like a comment on PRs. In the future maybe thats a fun sideproject for someone to do but for now there isnt anything like that :)
enhancementThis would be an improvement to the website.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MTRNord
force-pushed
the
MTRNord/playwright
branch
from
Some more recent issues (#2278 , #2276 , #2261 and #2180 and probably others) have shown a pattern of things that may be possible to catch with testing. So I decided to get a stab at building a simple playwright based testsuite for this.
The testsuite will also bring tests for accessibility based on https://playwright.dev/docs/accessibility-testing which hopefully helps us on that front as well.
Skipped ones are due to issues beyond the scope of the PR.
For example these kinds of accessibility errors:
TODO: