Refactoring GUI out of the ReportManager. #188
Conversation
This will let us later use the GUI code for the Trashcan.
|
|
||
| /// Regexp, used to extract the action label from an action reaction | ||
| /// such as `⚽ Kick user @foobar:localhost from room [kick-user]`. | ||
| const REACTION_ACTION = /\[([a-z-]*)\]$/; |
There was a problem hiding this comment.
Could we look at #137 (comment) again? seems like it's been merged into spec now
There was a problem hiding this comment.
Good point. That would definitely be nicer.
This means that the feature will only work with recent versions of Synapse, though.
| if (interactionRoomId === this.interactionRoomId) { | ||
| // Always accept actions executed from the interaction room. | ||
| } else { | ||
| throw new Error("Security error: Cannot execute this action."); |
There was a problem hiding this comment.
are we going to be able to see which action this is?
| } | ||
| response = await action.execute(this.owner, report, interactionRoomId, this); | ||
| } catch (ex) { | ||
| error = ex; |
There was a problem hiding this comment.
do we ever log this exception or is the thinking that the Action should do that? Might be a little risky leaving it to the action
| export type Actions<Owner extends { mjolnir: Mjolnir }> = [string /* label */, IUIAction<Owner>][]; | ||
|
|
||
| export class GUIManager<Owner extends { mjolnir: Mjolnir }> { | ||
| private readonly owner: Owner; |
| * Note: These reports end up embedded in Matrix messages, behind key `ABUSE_ACTION_CONFIRMATION_KEY`, | ||
| * so we're using Matrix naming conventions rather than JS/TS naming conventions. | ||
| */ | ||
| export interface IReportWithAction extends IReport { |
There was a problem hiding this comment.
is this supposed to generalise the reaction based UI? then why would we have report stuff in this file?
| } | ||
|
|
||
| export function getHomeserver(userId: string): string { | ||
| return new UserID(userId).domain |
There was a problem hiding this comment.
Ahh, that's nice that matrix-bot-sdk has that 😺
| /** | ||
| * A user action displayed in the UI as a Matrix reaction. | ||
| */ | ||
| export interface IUIAction<Manager extends { mjolnir: Mjolnir }> { |
There was a problem hiding this comment.
So is the manager a GuiManager or is it one of these owners or something else?
| const REACTION_CONFIRMATION = /\[([a-z-]*)\]\[([a-z-]*)\]$/; | ||
|
|
||
| export const NATURE_DESCRIPTIONS_LIST: readonly [string, string][] = Object.freeze([ | ||
| ["org.matrix.msc3215.abuse.nature.disagreement", "disagreement"], |
There was a problem hiding this comment.
this is good, are we keeping that MSC alive?
This will let us later use the GUI code for the Trashcan.