Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for blocking specific app/version/label combinations #85

Merged
merged 6 commits into from
May 10, 2024

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented May 9, 2024

No description provided.

@kegsay kegsay requested a review from richvdh as a code owner May 9, 2024 17:06
@@ -99,7 +99,7 @@ type issueBodyTemplatePayload struct {
type genericWebhookPayload struct {
payload
// If a github/gitlab report is generated, this is set.
ReportURL string `json:"report_url"`
ReportURL string `json:"report_url"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking comment: any idea why this is happening? Has gofmt changed the rules about struct formatting?I'm not convinced that the updated style is an improvement, but I don't care that much as long as we're not just going to flip-flop between the two.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure why this is happening tbh. Empirically, this is what go fmt . does, so it's not an IDE thing.

go version
go version go1.22.1 darwin/arm64

Copy link
Member

@richvdh richvdh May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empirically, this is what go fmt . does,

same for me. weird.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tip.golang.org/doc/go1.19#go-doc are you on an old version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I'm saying that I'm on go1.22, and it does the same as you. It's entirely possible the current formatting came from an earlier version of go. Thanks for hunting down the changes.

submit.go Show resolved Hide resolved
main.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
rageshake.sample.yaml Show resolved Hide resolved
@kegsay kegsay requested a review from richvdh May 10, 2024 09:11
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rageshake.sample.yaml Outdated Show resolved Hide resolved
Co-authored-by: Richard van der Hoff <[email protected]>
@kegsay kegsay merged commit 4e8622d into main May 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants