Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove global load position #156

Merged
merged 9 commits into from
Jun 15, 2023
Merged

Remove global load position #156

merged 9 commits into from
Jun 15, 2023

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Jun 13, 2023

This enables more concurrency upstream.

@kegsay kegsay requested a review from DMRobertson June 13, 2023 09:21
DMRobertson
DMRobertson approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks sane, but please sanity check my understanding.

DMRobertson
DMRobertson approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once that test is passing

@kegsay kegsay merged commit 409431f into main Jun 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kegsay @DMRobertson