Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more metrics around connection buffers #219

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Add more metrics around connection buffers #219

merged 4 commits into from
Jul 24, 2023

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Jul 24, 2023

No description provided.

@kegsay kegsay requested a review from DMRobertson July 24, 2023 13:17
DMRobertson
DMRobertson reviewed Jul 24, 2023
View reviewed changes
sync3/connmap.go Outdated Show resolved Hide resolved
DMRobertson
DMRobertson approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane otherwise. Have we sanity-checked this with SYNCV3_PROM enabled?

@kegsay
Copy link
Member Author

kegsay commented Jul 24, 2023

Yes I sanity checked with SYNCV3_PROM.

@kegsay kegsay merged commit 1be61c1 into main Jul 24, 2023
@DMRobertson DMRobertson mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kegsay @DMRobertson