Add metadata-action so labels are generated

[halkeye]

I use renovate to make sure my deployed apps are up to date. (halkeye/home-k8s#116) and according to the documentation if the source docker label is set, it'll actually pull in the release notes.

I checked the latest release, and it doesn't seem to have the labels (or any labels) set, so using the pre-existing github action should populate all the nice metadata.

regctl image config --format '{{ jsonPretty .Config.Labels }}' ghcr.io/matrix-org/sliding-sync
null

Pull Request Checklist

• Pull request includes a sign off

[kegsay]

I don't know enough about this which is why it's taken me a while to look into this.

I'll need you to walk me through your changes and justify them. Thanks.

[kegsay]

We seem to be losing the :latest tag..?

[halkeye]

So the latest tag is no longer specified by docker/build-push-action@v4, but a list of tags (in this case I think only one) is created by docker/metadata-action@v5

See

sliding-sync/.github/workflows/docker.yml

Line 46 in 8bcd28b

${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/')) && 'type=raw,value=latest' }}

It'll create main on main branch, latest on release, and then always a sha specific tag

[kegsay]

We seem to lose the caching..?

[halkeye]

I feel like this diff is just because i merged them into the one docker/build-push-action@v4

Though that being said, i think the if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') should be removed so its always pushing an email? or did you only want images pushed for releases? its been a few weeks.

[halkeye]

No wait yes, the if: should be removed so it always builds the image, but maybe the push: true could be made into a conditional so only pushes the result sometimes?

[halkeye]

I'll need you to walk me through your changes and justify them. Thanks.

Yea thats cool, i'm only just starting to learn about labels because of my k8s lab.

I think the diff is making it more confusing than it should be too.

[halkeye]

Fixed a typo, it now runs
https://github.com/halkeye/sliding-sync/actions/runs/9395229608/job/25874257317 for example output on a branch (just builds, no push)

Example version - v0.0.1
https://github.com/halkeye/sliding-sync/actions/runs/9395286907/job/25874424720
https://github.com/halkeye/sliding-sync/pkgs/container/halkeye%2Fsliding-sync

(I have a bug cause one tag is "false")

[halkeye]

https://github.com/halkeye/sliding-sync/actions/runs/9395428499
https://github.com/halkeye/sliding-sync/pkgs/container/halkeye%2Fsliding-sync/226245448?tag=latest

regctl image config --format '{{ jsonPretty .Config.Labels }}' ghcr.io/halkeye/halkeye/sliding-sync:latest
{
  "org.opencontainers.image.created": "2024-06-06T05:08:55.274Z",
  "org.opencontainers.image.description": "Proxy implementation of MSC3575's sync protocol.",
  "org.opencontainers.image.licenses": "Apache-2.0",
  "org.opencontainers.image.revision": "5f014bff281a49d1a4213dd3be20190a413a7a9f",
  "org.opencontainers.image.source": "https://github.com/halkeye/sliding-sync",
  "org.opencontainers.image.title": "sliding-sync",
  "org.opencontainers.image.url": "https://github.com/halkeye/sliding-sync",
  "org.opencontainers.image.version": "v0.0.2"
}