Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for FCM v1 API #361

Merged
merged 9 commits into from
Feb 15, 2024
Merged

Support for FCM v1 API #361

merged 9 commits into from
Feb 15, 2024

Conversation

devonh
Copy link
Contributor

@devonh devonh commented Feb 12, 2024

This adds support for the new FCM v1 API.
Major changes introduced:

  • can only send to a single device per request, no more batch sending
  • push data format changes, only string: string entries are allowed in the data section
  • small config tweaks

@devonh devonh requested a review from a team as a code owner February 12, 2024 15:16
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! Have we tested this in the wild at all?

@devonh devonh merged commit c8a85fd into main Feb 15, 2024
5 checks passed
@devonh devonh deleted the devon/fcm-update branch February 15, 2024 16:03
@octopop
Copy link

octopop commented Mar 8, 2024

@devonh What is the ETA or plan to release these changes as a tagged release and updated docker image?

chaugioi18 pushed a commit to chaugioi18/sygnal that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants