Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow twisted versions >=23.10 #381

Merged
merged 3 commits into from
May 31, 2024
Merged

Allow twisted versions >=23.10 #381

merged 3 commits into from
May 31, 2024

Conversation

devonh
Copy link
Contributor

@devonh devonh commented May 30, 2024

Fixes #356

Fix done in synapse first: matrix-org/synapse#16528
Follows a similar pattern to what twisted does internally for testing: https://github.com/twisted/twisted/blob/157cd8e659705940e895d321339d467e76ae9d0a/src/twisted/web/test/test_agent.py#L871-L874

@devonh devonh requested a review from a team as a code owner May 30, 2024 20:12
@devonh devonh merged commit 178ff86 into main May 31, 2024
5 checks passed
@devonh devonh deleted the devon/twisted-23.10 branch May 31, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing with Twisted 23.10
2 participants