Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Refactor the configure_workers_and_start.py script used internally by Complement. #16650

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Refactor the configure_workers_and_start.py script used internally by Complement. #16650

wants to merge 18 commits into from

Commits on Nov 17, 2023

  1. Remove obsolete "app" from worker templates

    @reivilibre
    reivilibre committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b39a50a View commit details
    Browse the repository at this point in the history

  2. Convert worker templates into dataclass

    @reivilibre
    reivilibre committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    a22eb7d View commit details
    Browse the repository at this point in the history

  3. Use a lambda for the worker name rather than search and replace later

    @reivilibre
    reivilibre committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    ba3b6a4 View commit details
    Browse the repository at this point in the history

  4. Collapse WORKERS_CONFIG by removing entries with defaults

    @reivilibre
    reivilibre committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    67d4fc8 View commit details
    Browse the repository at this point in the history

  5. Convert listener_resources and endpoint_patterns to Set[str]

    @reivilibre
    reivilibre committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    94a85b3 View commit details
    Browse the repository at this point in the history

  6. Tweak comments

    @reivilibre
    reivilibre committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    26073fa View commit details
    Browse the repository at this point in the history

  7. Add merge_into

    @reivilibre
    reivilibre committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    8b74639 View commit details
    Browse the repository at this point in the history

  8. Remove special logic for adding stream_writers: just make it part of … 

    …the extra config template
    @reivilibre
    reivilibre committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    f38297b View commit details
    Browse the repository at this point in the history

  9. Rename function to add_worker_to_instance_map given reduction of scope

    @reivilibre
    reivilibre committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    7d8824e View commit details
    Browse the repository at this point in the history

  10. Add sharding_allowed to the WorkerTemplate rather than having a sep… 

    …arate function for that
    @reivilibre
    reivilibre committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    f49dbc7 View commit details
    Browse the repository at this point in the history

  11. Use merge_into when adding workers to the shared config

    @reivilibre
    reivilibre committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    3bb21a9 View commit details
    Browse the repository at this point in the history

  12. Promote mark_filepath to constant

    @reivilibre
    reivilibre committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    fbafde8 View commit details
    Browse the repository at this point in the history

  13. Add a --generate-only option

    @reivilibre
    reivilibre committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    321d359 View commit details
    Browse the repository at this point in the history

  14. Newsfile 

    Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
    @reivilibre
    reivilibre committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    576cade View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Docstring on WorkerTemplate

    @reivilibre
    reivilibre committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    f647745 View commit details
    Browse the repository at this point in the history

  2. Fix comment and mutation bug on merge_worker_template_configs

    @reivilibre
    reivilibre committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    a0d1348 View commit details
    Browse the repository at this point in the history

  3. Update comment on merged

    @reivilibre
    reivilibre committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    3318722 View commit details
    Browse the repository at this point in the history

  4. Tweak instantiate_worker_template, both in name, description and va… 

    …riable names
    @reivilibre
    reivilibre committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    da040e1 View commit details
    Browse the repository at this point in the history