Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Use Python 3.12 for asyncio CI #16685

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Conversation

erikjohnston
Copy link
Member

Hopefully to make it faster?

@erikjohnston
Copy link
Member Author

Trying using uvloop has (fairly predictably) had no effect.

@@ -226,6 +226,8 @@ pydantic = ">=1.7.4, <3"
# needed.
setuptools_rust = ">=1.3"

uvloop = ">=0.19.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the reactor tick timing stuff won't work with uvloop. I think I tried to support it briefly and then decided we probably weren't going to use it...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful context! Was mainly wondering if using a different event loop would change how fast it'd run, but alas not. I guess there is just some extra overhead maybe?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the asyncio reactor you end up doing some bookkeeping twice, which is annoying. I'm kind of surprised it is that much of a difference though, I wish we had a good benchmark for running this through instead of sytest.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants