Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes on client guidelines and link to docs. #64

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

michaelkaye
Copy link
Contributor

No description provided.

@michaelkaye
Copy link
Contributor Author

@MidhunSureshR @bwindels would be interested in thoughts/feedback on what i've expressed here so far on naming etc.

@michaelkaye
Copy link
Contributor Author

Fixes #44

Copy link
Contributor

@MidhunSureshR MidhunSureshR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* `create_poll` not `pr_52_action` or `msc_1235_action`

We Should avoid naming actions in a client specific way
* `clear_idb_cache` is not great because it's only available in element web
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't client specific but rather platform specific. I imagine similar actions would be needed for other platforms as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added some possibly clearer negative examples around mouse hovering etc.

@michaelkaye michaelkaye marked this pull request as ready for review November 28, 2022 14:51
@michaelkaye michaelkaye merged commit e1b8f82 into main Nov 28, 2022
@michaelkaye michaelkaye deleted the michaelk/document_best_practices branch December 7, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants