-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Go in a more idiomatic way #126
Commits on Feb 6, 2023
-
peer: remove unnecessary accidental complexity
There was no point requesting the key frame by sending a message to the conference as the only thing that the conference did was calling a single function from the peer, so it was completely wasting the CPU time. Instead, we could directly call this function and write to the peer connection. The function is thread-safe since all mutable state is protected by a mutex and the peer connection has a mutex inside.
Configuration menu - View commit details
-
Copy full SHA for a439489 - Browse repository at this point
Copy the full SHA a439489View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d0a14e - Browse repository at this point
Copy the full SHA 8d0a14eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4386f4d - Browse repository at this point
Copy the full SHA 4386f4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11d83f6 - Browse repository at this point
Copy the full SHA 11d83f6View commit details -
subscription: reduce the buffer on worker
This solves the problem with managing the queue size on the receiver.
Configuration menu - View commit details
-
Copy full SHA for 36b3fc7 - Browse repository at this point
Copy the full SHA 36b3fc7View commit details -
router: remove the buffer on incoming channel
It's ok if the matrix SDK blocks until we're ready to accept new messages.
Configuration menu - View commit details
-
Copy full SHA for 5376a7a - Browse repository at this point
Copy the full SHA 5376a7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b03eb1a - Browse repository at this point
Copy the full SHA b03eb1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9486575 - Browse repository at this point
Copy the full SHA 9486575View commit details -
router: refactor the router in a more idiomatic Go
Use unbounded channels for that. We can't quite use it for the multi-conference set ups as a single conference will affect others, but currently we don't have these problems.
Configuration menu - View commit details
-
Copy full SHA for 9315323 - Browse repository at this point
Copy the full SHA 9315323View commit details -
track: move track info out of
common
Usage of `common` is an anti-pattern.
Configuration menu - View commit details
-
Copy full SHA for 4ce8b07 - Browse repository at this point
Copy the full SHA 4ce8b07View commit details -
worker: move to its own package
Package `common` is an antipattern.
Configuration menu - View commit details
-
Copy full SHA for 974f469 - Browse repository at this point
Copy the full SHA 974f469View commit details -
sink: move to the
channel
moduleThe `common` package is an antipattern.
Configuration menu - View commit details
-
Copy full SHA for 20b5085 - Browse repository at this point
Copy the full SHA 20b5085View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94d0b62 - Browse repository at this point
Copy the full SHA 94d0b62View commit details -
This is a temporary measure until we can workaround bugs in Pion that lead to the deadlocks.
Configuration menu - View commit details
-
Copy full SHA for 4ae95a8 - Browse repository at this point
Copy the full SHA 4ae95a8View commit details
Commits on Feb 8, 2023
-
router: rename
RunRouter
toStartRouter
So it better reflects the semantics (that the function does not block).
Configuration menu - View commit details
-
Copy full SHA for eff418b - Browse repository at this point
Copy the full SHA eff418bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b40d6ad - Browse repository at this point
Copy the full SHA b40d6adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c4ea8f - Browse repository at this point
Copy the full SHA 7c4ea8fView commit details