Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go in a more idiomatic way #126

Merged
merged 17 commits into from
Feb 9, 2023
Merged

Commits on Feb 6, 2023

  1. peer: remove unnecessary accidental complexity

    There was no point requesting the key frame by sending a message to the
    conference as the only thing that the conference did was calling a
    single function from the peer, so it was completely wasting the CPU
    time. Instead, we could directly call this function and write to the
    peer connection. The function is thread-safe since all mutable state is
    protected by a mutex and the peer connection has a mutex inside.
    daniel-abramov committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    a439489 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8d0a14e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4386f4d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    11d83f6 View commit details
    Browse the repository at this point in the history
  5. subscription: reduce the buffer on worker

    This solves the problem with managing the queue size on the receiver.
    daniel-abramov committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    36b3fc7 View commit details
    Browse the repository at this point in the history
  6. router: remove the buffer on incoming channel

    It's ok if the matrix SDK blocks until we're ready to accept new
    messages.
    daniel-abramov committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    5376a7a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b03eb1a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9486575 View commit details
    Browse the repository at this point in the history
  9. router: refactor the router in a more idiomatic Go

    Use unbounded channels for that. We can't quite use it for the
    multi-conference set ups as a single conference will affect others, but
    currently we don't have these problems.
    daniel-abramov committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    9315323 View commit details
    Browse the repository at this point in the history
  10. track: move track info out of common

    Usage of `common` is an anti-pattern.
    daniel-abramov committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    4ce8b07 View commit details
    Browse the repository at this point in the history
  11. worker: move to its own package

    Package `common` is an antipattern.
    daniel-abramov committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    974f469 View commit details
    Browse the repository at this point in the history
  12. sink: move to the channel module

    The `common` package is an antipattern.
    daniel-abramov committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    20b5085 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    94d0b62 View commit details
    Browse the repository at this point in the history
  14. conference: get back buffers

    This is a temporary measure until we can workaround bugs in Pion that
    lead to the deadlocks.
    daniel-abramov committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    4ae95a8 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. router: rename RunRouter to StartRouter

    So it better reflects the semantics (that the function does not block).
    daniel-abramov committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    eff418b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b40d6ad View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7c4ea8f View commit details
    Browse the repository at this point in the history