Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactor for delaying calls to expand ranges #20769

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Small refactor for delaying calls to expand ranges #20769

wants to merge 18 commits into from

Conversation

triump2020
Copy link
Contributor

@triump2020 triump2020 commented Dec 16, 2024 •
edited
Loading

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #20767

What this PR does / why we need it:

  1. Even if delay calls to expand ranges , uncommitted tombstones need to be broadcast to all remote CNs.
  2. Fix bug :lost tombstones ,leads to Duplication error in multi CNs scenario.
  3. Add integration test for DML.

@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label Dec 16, 2024
@triump2020 triump2020 requested a review from badboynt1 December 23, 2024 10:35
@matrix-meow matrix-meow added size/L Denotes a PR that changes [500,999] lines and removed size/M Denotes a PR that changes [100,499] lines labels Dec 23, 2024
@triump2020 triump2020 mentioned this pull request Jan 6, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingxinhome qingxinhome qingxinhome approved these changes

@m-schen m-schen m-schen approved these changes

@ouyuanning ouyuanning ouyuanning approved these changes

@zhangxu19830126 zhangxu19830126 zhangxu19830126 approved these changes

@aunjgr aunjgr aunjgr approved these changes

@XuPeng-SH XuPeng-SH Awaiting requested review from XuPeng-SH XuPeng-SH is a code owner

@badboynt1 badboynt1 Awaiting requested review from badboynt1 badboynt1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/enhancement size/L Denotes a PR that changes [500,999] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@triump2020 @aunjgr @zhangxu19830126 @ouyuanning @m-schen @qingxinhome @badboynt1 @matrix-meow