Fix symlinks for git annex #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrss
force-pushed
the
fix-symlinks-for-git-annex
branch
4 times, most recently
from
8b573e6 to
5208eda
Compare
matrss
force-pushed
the
fix-symlinks-for-git-annex
branch
9 times, most recently
from
73589f5 to
9ae09f6
Compare
Previously a sub-path of an ignored directory was not considered to be
ignored, e.g. is_ignored returned False for a file build/hello.py even
if _all_ignored_files contained Path("build"). Instead of just checking
if the path is in the ignored files we also have to check if it is
inside of an ignored directory.
Additionally this commit fixes a bug that surfaced: when building the
_all_ignored_files set all_files contains an empty string as its last
element. This leads to Path(".") being an element in _all_ignored_files,
i.e. ignore everything. Using all but the last element from all_files
fixes that.
These tests assume the interpretation of the REUSE specification that: 1. a symlink pointing to a covered file is considered to be the same file as the covered file and can therefore be ignored. 2. a symlink pointing to a file that is not a covered file is itself considered to be a covered file and should not be ignored, unless the symlink itself is ignored by other means.
matrss
force-pushed
the
fix-symlinks-for-git-annex
branch
from
9ae09f6 to
fbb5ed2
Compare
matrss
force-pushed
the
fix-symlinks-for-git-annex
branch
from
fbb5ed2 to
13e4fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the heuristic for better handling of symlinks as described in fsfe#627 (comment).
Basically, this is based on an interpretation of the REUSE specification that:
file as the covered file and can therefore be ignored.
considered to be a covered file and should not be ignored, unless the
symlink itself is ignored by other means.