US7 // parts detailPage #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mpagels
approved these changes
Jun 29, 2023
components/PartForm/index.js
Outdated
Comment on lines
19
to
22
| const uuid4 = uuidv4(); | ||
|
|
||
| const newPart = { | ||
| uuid: uuid4, |
There was a problem hiding this comment.
You can just use uuid4() while creating the object newPart and save one line of code
Suggested change
| const uuid4 = uuidv4(); | |
| const newPart = { | |
| uuid: uuid4, | |
| const newPart = { | |
| uuid: uuidv4(), |
There was a problem hiding this comment.
oh great advice 👌 thanks
i'll fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ✌🏼
i also set borderSize values to global variables
US7
Deployment