US11 // parts - highlight active filters #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so for statusFilter
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
actyvystom
reviewed
Jul 5, 2023
components/PartsList/index.js
Outdated
| ]} | ||
| activeFilter={activeCategoryFilter} | ||
| /> | ||
| <StyledFilter | ||
| sets={[ |
There was a problem hiding this comment.
A smart idea to populate your filters! 🚀
I suggest some naming changes to shed some light on it for external reviewers (and for yourself in the future when you review your code again after some time has passed 😉 )
{
primaryFunction: setStatusFilter,
primaryValue: "alle",
filterName: "alle",
secondaryFunction: setActiveStatusFilter,
secondaryValue: "alle",
}There was a problem hiding this comment.
Thanks for your advise. I will stay consistent in naming from now on ✌🏼
it looks much better now
|
// reworked naming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
highlighted the active filter for each of the filter-slider
US11
Deployment
click a filter and see the highlighting. (just a little bit)