Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mat sim #90

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Update mat sim #90

merged 6 commits into from
Nov 6, 2024

Conversation

tschlenther
Copy link
Contributor

No description provided.

@tschlenther
Copy link
Contributor Author

also set the version number to 2024.2

@tschlenther
Copy link
Contributor Author

for some reason, now the .avro files generated for the AverageKelheimNoiseDashboard are almost empty... I had update change the avro dependency to stay up to date with the version in matsim-libs...
@simei94 can you see any other reason why this suddenly doesn't work, anymore? The test also fails...

@tschlenther
Copy link
Contributor Author

i just tested again and on the master, the average avros are fine and the dashboard works... super strange

@simei94
Copy link
Contributor

simei94 commented Oct 2, 2024

So, is this resolved then?

@simei94 simei94 closed this Oct 2, 2024
@simei94 simei94 reopened this Oct 2, 2024
@tschlenther
Copy link
Contributor Author

tschlenther commented Oct 2, 2024

no. it's broken here, but works on the master. see the test results.

@simei94
Copy link
Contributor

simei94 commented Oct 10, 2024

@tschlenther the NoiseAverageAnalysis now works again. It was due to a object / datatype change in .avro files from GenericData arrays to PrimitivesArrays, both part of the apache avro package. The package must have been updated in matsim-libs and therefore it did not work after the matsim version update

Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
14.6% Duplication on New Code (required ≤ 5%)

See analysis details on SonarCloud

@tschlenther tschlenther merged commit 27a106d into master Nov 6, 2024
4 of 5 checks passed
@tschlenther tschlenther deleted the updateMATSim branch November 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants