Drop Redmine versions (3.4, 3.3, 3.2)

.travis.yml

@@ -1,42 +1,33 @@
 
 language: ruby
 
-# http://www.redmine.org/projects/redmine/wiki/RedmineInstall
 rvm:
-  - 1.9.3
-  - 2.0.0
-  - 2.1
   - 2.2
   - 2.3
   - 2.4
+  - 2.5
+  - 2.6
 
 env:
-  - REDMINE_REPOS=branches/3.4-stable
-  - REDMINE_REPOS=branches/3.3-stable
-  - REDMINE_REPOS=branches/3.2-stable
-
-gemfile:
-  - $REDMINE_PATH/Gemfile
-
-matrix:
-  allow_failures:
-    - rvm: 2.4
+  - REDMINE_REPOS=branches/4.0-stable
 
 before_install:
   - export PLUGIN_NAME=redmine_serial_number_field
   - export DB=sqlite
   - export NOKOGIRI_USE_SYSTEM_LIBRARIES=true
   - export REDMINE_PATH=$HOME/redmine
+  - export BUNDLE_GEMFILE=$REDMINE_PATH/Gemfile
   - svn co http://svn.redmine.org/redmine/$REDMINE_REPOS $REDMINE_PATH
   - ln -s $TRAVIS_BUILD_DIR $REDMINE_PATH/plugins/$PLUGIN_NAME
   - cp test/database.travis.yml $REDMINE_PATH/config/database.yml
   - cd $REDMINE_PATH
+  - bundle update
 
 before_script:
-  - bundle exec rake db:migrate
+  - bundle exec rails db:migrate
 
 script:
-  - RUBYOPT=-W0 bundle exec rake redmine:plugins:test NAME=$PLUGIN_NAME
+  - bundle exec rails redmine:plugins:test NAME=$PLUGIN_NAME RAILS_ENV=test
 
 branches:
   only:

CHANGELOG.md

@@ -0,0 +1,15 @@
+## 2.0.0
+
+- Support Redmine 4.0 (@nanego)
+- Support French locale (@nanego)
+- Drop support Redmine version 3.4 lower (@maeda-m)
+
+## 1.0.0
+
+- Changed the range to count sequential numbers from project unit to whole sharing as custom field unit #4 (@neocosmic2)
+
+## 0.9.0
+
+- Support Turkish locale #3 (@atopcu)
+- Allow only sequence numbers #2 (@y-arai)
+- Drop support Redmine versions 2.6 and 3.1 (@maeda-m)

Gemfile

@@ -1 +1,6 @@
 gem 'fiscali'
+
+group :test do
+  gem 'rails-controller-testing'
+  gem 'byebug'
+end

README.en.md

@@ -50,7 +50,7 @@ Add a format to be serial number in the specified format as a issue custom field
 
 ## Supported versions
 
-* Redmine 3.2.x or higher
+* Redmine 4.0 (Ruby 2.2, 2.3, 2.4, 2.5, 2.6)
 
 ## Format specifications
 

README.md

@@ -50,7 +50,7 @@ Redmine に自動で連番を付加するカスタムフィールドを提供す
 
 ## Supported versions
 
-* Redmine 3.2.x or higher
+* Redmine 4.0 (Ruby 2.2, 2.3, 2.4, 2.5, 2.6)
 
 ## Format specifications
 

app/patches/issue_custom_field_patch.rb

@@ -4,23 +4,18 @@ module SerialNumberField
   module IssueCustomFieldPatch
     extend ActiveSupport::Concern
 
-    included do
-      unloadable
+    def validate_custom_field
+      super
 
-      def validate_custom_field
-        super
+      invalid_message = l('activerecord.errors.messages.invalid')
+      if errors[:regexp].include?(invalid_message) && field_format == SerialNumberField::Format::NAME
+        regexp_error_messages = errors[:regexp].clone
 
-        invalid_message = l('activerecord.errors.messages.invalid')
-        if errors[:regexp].include?(invalid_message) && field_format == SerialNumberField::Format::NAME
-          regexp_error_messages = errors[:regexp].clone
-
-          errors.delete(:regexp)
-          regexp_error_messages.each do |regexp_error_message|
-            errors[:regexp] = regexp_error_message unless regexp_error_message == invalid_message
-          end
+        errors.delete(:regexp)
+        regexp_error_messages.each do |regexp_error_message|
+          errors[:regexp] = regexp_error_message unless regexp_error_message == invalid_message
         end
       end
-
     end
 
   end

app/patches/issue_patch.rb

@@ -3,11 +3,8 @@
 module SerialNumberField
   module IssuePatch
     extend ActiveSupport::Concern
-    unloadable
 
     included do
-      unloadable
-
       after_save :assign_serial_number!
     end
 

config/locales/tr.yml

@@ -1,4 +1,3 @@
-
 tr:
   label_serial_number: Otomatik Seri No
 

init.rb

@@ -2,8 +2,8 @@
   name 'Redmine Serial Number Field'
   author 'Matsukei Co.,Ltd'
   description 'Add a format to be serial number in the specified format as a issue custom field.'
-  version '1.0.0'
-  requires_redmine version_or_higher: '2.6'
+  version '2.0.0'
+  requires_redmine version_or_higher: '4.0'
   url 'https://github.com/matsukei/redmine_serial_number_field'
   author_url 'http://www.matsukei.co.jp/'
 end

test/functional/custom_fields_controller_test.rb

@@ -26,7 +26,7 @@ def test_new_should_serial_number_format_has_only_issue
       format_name = SerialNumberField::Format::NAME
       expect_selected =  'IssueCustomField' == type ? 1 : 0
 
-      get :new, {
+      get :new, :params => {
           :type => type,
           :custom_field => {
             :field_format => format_name
@@ -43,7 +43,7 @@ def test_new_should_serial_number_format_has_only_issue
   end
 
   def test_new_serial_number_format
-    get :new, {
+    get :new, :params => {
         :type => 'IssueCustomField',
         :custom_field => {
           :field_format => SerialNumberField::Format::NAME
@@ -72,7 +72,7 @@ def test_create_serial_number_field
     valid_regexp_values.each_with_index do |valid_regexp, i|
       field_name = "auto_number_#{i.next}"
       field = new_record(IssueCustomField) do
-        post :create, {
+        post :create, :params => {
             :type => "IssueCustomField",
             :custom_field => {
               :field_format => "serial_number",
@@ -101,7 +101,7 @@ def test_create_serial_number_field
   def test_create_serial_number_field_with_failure
     invalid_regexp_values.each_with_index do |invalid_regexp, i|
       assert_no_difference 'CustomField.count' do
-        post :create, {
+        post :create, :params => {
             :type => "IssueCustomField",
             :custom_field => {
               :field_format => "serial_number",
@@ -121,7 +121,7 @@ def test_create_serial_number_field_with_failure
   def test_edit_serial_number_field
     custom_field = create_default_serial_number_field
 
-    get :edit, {
+    get :edit, :params => {
         :id => custom_field.id
       }
 
@@ -135,7 +135,7 @@ def test_update_serial_number_field
     custom_field = create_default_serial_number_field
 
     valid_regexp_values.each_with_index do |valid_regexp, i|
-      put :update, {
+      put :update, :params => {
           :id => custom_field.id,
           :custom_field => {
             :regexp => valid_regexp
@@ -152,7 +152,7 @@ def test_update_serial_number_field_with_failure
     custom_field = create_default_serial_number_field
 
     invalid_regexp_values.each_with_index do |invalid_regexp, i|
-      put :update, {
+      put :update, :params => {
           :id => custom_field.id,
           :custom_field => {
             :regexp => invalid_regexp