Use original filename for cache key

[lthurston]

See issue #52

[lthurston]

This is a pretty straight forward change. Let me know if you want to see any modifications.

[lthurston]

@toughdeveloper Is this project being managed anymore?

[chocolata]

I haven't seen a response from @toughdeveloper in months. I'm not feeling very confident about this. Maybe someone should fork the project, so we can get on with it?

[lthurston]

Yeah, it would be pretty ridiculous for us all to maintain our own forks. I can start a new issue and mention everyone who has an open PR to see who would be willing to take this on. I would be willing to manage the fork, but can't promise I'll always have enough time to deal with it.

[matt-pawley]

@lthurston @maartenmachiels - Hi, Sorry for not responding sooner. I don't have time to maintain this anymore.

Feel free to fork, I will update the readme to point to a maintained version.

[lthurston]

Thanks, @toughdeveloper, for letting us know and also for this useful plugin.

[lthurston]

See #55 for further discussion of project maintenance.

[matteotrubini]

I think that this enhancement will have high priority given the SEO best practices.

@lthurston this PR seems to be incomplete, maybe some commit are missing?

@maartenmachiels did you have check this PR before?

[chocolata]

Hi matteo, no I didn't check this before...

[lthurston]

Sorry @matteotrubini , little behind on email. This PR is complete and running in production environments (saving GB of disk space). It's a simple change that just uses the relative path to an original images rather than the complete path in generating the cache key.

[matteotrubini]

Can you explain how changes let's us to use original's relative path please?

[matteotrubini]

@lthurston please also rebase your commit on top of current develop, thank you!

[lthurston]

Actually, yeah, you're right. Something seems to be missing. I'll figure out what it is.

[lthurston]

@matteotrubini I've finally pushed the right changes. Sorry about the delay.

[lthurston]

Hi @matteotrubini, I'm just checking in and hoping this simple change can get merged in.

[lthurston]

Does anyone on this thread have a moment to +1 this? I'm anxious to getting it merged in because as mentioned in #52, all images get regenerated using our deploy setup (Capistrano deploys new releases to a uniquely named folder each time, then creates a symlink). We've got Composer configured to use our fork of this, but it'd be great to wrap this up.

[chocolata]

I just reviewed it - looks good to me. Do we have everything to proceed now? I'm also a big fan of keeping the original filenames. SEO-wise it's a great idea to keep those names descriptive.

[lthurston]

Thanks @maartenmachiels. @matteotrubini Any chance you can merge this bad boy in?

[chocolata]

@matteotrubini could you kindly do this?

[chocolata]

Thank you Matteo.