Develop #21
Open
Develop #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be implemented by someone running `$(".equal-heights").equalHeights({ wait: true });`
Basically, it keeps running equalHeights until the maxHeight is greater than 0. It's really annoying when equalHeights is implemented at a time before the content has loaded and it sets the elements to be a height of 0px. This prevents this only when specifically requested by the user. Also, this opens the door to have other potential options in the future.
Also, checking the height to be greater than "0" and the interval at "100" are arbitrary. These might be better as other options. Then the options could looks something like `{wait:true, minHeight: 100, interval: 75}`
Add option "wait"
With `option.watch` being `true` equalHeights is reexecuted when the window resizes
+ Tested the `watch` option function and refactored accordingly + Put the Auto initialization in document ready + Supporting options with data attributes
+ When `equalHeights` is called with {unwatch: true}, the elements are stopped being watched
+ All data-attributes are now passed in as options, so that new options don't need to be specified separately any more
Adding `watch` option among other things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, add $( window ).resize(function() to make it compatible with responsive.