Allow repository to edit where clause

[ThomasBleijendaal]

When developing a custom repository, it is sometimes required to adjust the way the where clause is generated. This change creates 3 override-able methods to alter the way the where clause is generated.

Examples why the where clause should be configurable:

• The default database access layer adds ToUpper to make where clauses case insensitive. This is not always the case when using a custom repository with, for example, Entity Framework.
• The StartsWith is not always the best method for the fuzzy finder, so sometimes searching using Contains is the better option.

Furthermore, this PR removes the skipping of the Name column in the orderBy clause. DefaultFluidityRepository uses _collection.SortProperty as a fallback for sorting, but that is unavailable for custom repositories. By never skipping the name column, the orderBy clause always has a usable value.

[mattbrailsford]

Hi Thomas,

Thank for spending the time to submit this PR. I totally understand the use case but I think I just need to give some thought to the implementation as I'm not sure it would be totally clear to other implementors.

There is a discussion on issue #73 about supporting a configurable SearchBehaviour to have a means to switch to Contains over StartsWith which I think might be a better option for this element. The other elements I need to give a little thought to.

[ThomasBleijendaal]

Hi,

I understand, but that is also why I implemented it as virtual methods. The generic, abstract FluidityRepository does not require the implementor to implement these methods themselves (unlike the *Impl methods), but when needed, can be overridden.

[mattbrailsford]

Sure, and that's cool, but my concern is the methods are quite broad in scope so unless you see this pr you might not be aware this is what they are for. I'd much rather expose a more specific, logical api if possible. I just need to think it through and see if the scope can be narrowed or if what we have here is good enough.

…

On Wed, 31 Oct 2018, 12:46 pm Thomas Bleijendaal ***@***.*** wrote: Hi, I understand, but that is also why I implemented it as virtual methods. The generic, abstract FluidityRepository does not require the implementor to implement these methods themselves (unlike the *Impl methods), but when needed, can be overridden. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#79 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAgLyfV6cH-7ykYGk6dPXZ0sZsq-rBnRks5uqZuNgaJpZM4YCzJq> .

[nehanupur0507]

Is this change still happening??