-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the Quint specification after #144 #146
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have fixed |
konnov
added a commit
that referenced
this pull request
Jul 17, 2024
konnov
changed the title
WIP: Refactor the Quint specification after #144
Refactor the Quint specification after #144
Jul 27, 2024
dnkolegov
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Following the pseudo-code updates in #144, this PR introduces updates in the Quint specification, namely, moving
CommitQC
intoTimeoutQC
and storing onlyhigh_commit_qc_view
inTimeoutVote
instead of storinghigh_commit_qc
.Why ❔
This update speeds-up model checking times dramatically, as
CommitQC
fields inTimeoutVote
were a major bottleneck.This change has broken multiple invariants. Hence, we have to further fix the specification and the invariants before merging.Preliminary experiments show that the model checking times have improved dramatically. For instance, we were able to find the expected violation of agreement for
N=6
,F=1
, andB=2
.