-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for syncing pre-genesis blocks #203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach looks good. There is the inconsistency of post-genesis blocks being verified on era-consensus while pre-genesis blocks are verified on zksync-era. But this is probably only solvable when we move the eth watcher to era-consensus.
brunoffranca
previously approved these changes
Oct 8, 2024
brunoffranca
approved these changes
Oct 9, 2024
pompon0
pushed a commit
that referenced
this pull request
Oct 9, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.0](v0.4.0...v0.5.0) (2024-10-09) ### Features * support for syncing pre-genesis blocks ([#203](#203)) ([6a4a695](6a4a695)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will sync blocks with merkle proofs for the whole batches, which obsoletes the unused "batch syncing" logic that we had.
I've introduced a concept of PreGenesisBlock which contains a custom Justification, and a verify_pre_genesis_block() method in PersistentBlockStore for verifying those.
Some of the RPC requests required tuning to provide backward compatibility.
I've removed WIRE from protobuf compatibility check, since it is a subset of WIRE_JSON.