Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ZkUseFactoryDep cheatcode #671

Merged
merged 7 commits into from
Oct 30, 2024
Merged

feat: ZkUseFactoryDep cheatcode #671

merged 7 commits into from
Oct 30, 2024

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Oct 29, 2024

What 💻

  • Added ZkUseFactoryDep cheatcode to mark a bytecode as a factory dependency

Why ✋

  • This is particularly useful to deploy a contract with a factory like the tests added in this PR

Evidence 📷

image

@Jrigada Jrigada requested a review from a team as a code owner October 29, 2024 16:24
@Karrq Karrq added feature ➕ Feature item needs review 👓 PR requires a review p1 🟠 Indicates high priority item labels Oct 29, 2024
Karrq
Karrq requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@Karrq Karrq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I thought we'd pass these injected deps to the call/create execution contexts as well

crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/forge/tests/fixtures/zk/DeployMultisig.s.sol Outdated Show resolved Hide resolved
crates/forge/tests/fixtures/zk/DeployMultisig.s.sol Outdated Show resolved Hide resolved
crates/forge/tests/it/zk/cheats.rs Outdated Show resolved Hide resolved
elfedy
elfedy reviewed Oct 29, 2024
View reviewed changes
crates/cheatcodes/spec/src/vm.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/forge/tests/fixtures/zk/DeployMultisig.s.sol Outdated Show resolved Hide resolved
crates/forge/tests/fixtures/zk/TwoUserMultisig.sol Outdated Show resolved Hide resolved
@elfedy
Copy link
Contributor

elfedy commented Oct 29, 2024

Would add an actual foundry test using the functionalty as well so we make sure that use case also works

@Jrigada @elfedy
Update crates/cheatcodes/spec/src/vm.rs
9accac5 
Co-authored-by: Federico Rodríguez <[email protected]>
@Karrq Karrq removed the needs review 👓 PR requires a review label Oct 29, 2024
@Karrq Karrq linked an issue Oct 29, 2024 that may be closed by this pull request
Support injected factory deps #674
Open
4 tasks
@Karrq Karrq removed a link to an issue Oct 29, 2024
Support injected factory deps #674
Open
4 tasks
@Karrq Karrq mentioned this pull request Oct 29, 2024
Open
4 tasks
@tomimor tomimor linked an issue Oct 29, 2024 that may be closed by this pull request
Support injected factory deps #674
Open
4 tasks
@Jrigada Jrigada requested a review from Karrq October 29, 2024 19:48
nbaztec
nbaztec reviewed Oct 30, 2024
View reviewed changes
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Show resolved Hide resolved
@tomimor tomimor removed a link to an issue Oct 30, 2024
Support injected factory deps #674
Open
4 tasks
@Jrigada Jrigada requested a review from nbaztec October 30, 2024 14:00
@Jrigada Jrigada requested a review from nbaztec October 30, 2024 14:25
@Jrigada Jrigada merged commit 9093c3c into main Oct 30, 2024
11 checks passed
@Jrigada Jrigada deleted the feat-jrigada-zk-use-factory-dep-cheat branch October 30, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfedy elfedy elfedy left review comments

@nbaztec nbaztec nbaztec approved these changes

@Karrq Karrq Karrq approved these changes

Assignees

@Jrigada Jrigada

Labels
feature ➕ Feature item p1 🟠 Indicates high priority item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jrigada @elfedy @nbaztec @Karrq