Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates cross chain #47

Merged
merged 5 commits into from
Jul 31, 2024
Merged

fix: updates cross chain #47

merged 5 commits into from
Jul 31, 2024

Conversation

uF4No
Copy link
Contributor

@uF4No uF4No commented Jul 22, 2024

What 💻

Why ✋

  • Outdated tutorial

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Notes 📝

  • Any notes/thoughts that the reviewers should know prior to reviewing the code?

I had to hardcode the url of the provider as http://127.0.0.1:3050 in the hello-world-docker/tests/main.test.ts file cause even if I use that value in the hardhat.config.ts file, getDefaultProvider replaces it with localhost which seems not to work in the CI job.

@bxpana bxpana merged commit 15400f9 into main Jul 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants