fix: More metric / label name validations #16

slowli · 2023-10-10T10:56:13Z

What ❔

Unifies metric and label name validation and performs it using functions from the main crate. Previously, label names were not checked in some cases.
Improves spanning of validation errors.
Tests errors using trybuild.

Label name validation is necessary to conform to Prometheus / Open Metrics text formats.
More intelligent error messages and spanning improve DevX.

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
~~Documentation comments have been added / updated.~~ not applicable
Code has been formatted and linted using cargo fmt and cargo clippy.

...using `compile-fmt` crate

slowli added 8 commits October 10, 2023 13:51

Sketch unified metric and label name validation

5fecee0

Fix spans for name assertions

104ebcd

Specify more spans for generated code

8f9c82f

Add track_caller attr for assertion functions

9462e10

Check Metrics macro UI with trybuild

63e36b2

Improve error messages / spans for label macros

9abb170

Test error messages / spans for label macros

ceb2e01

Install Rust sources in build CI job

8d0fab9

slowli marked this pull request as ready for review October 10, 2023 12:28

slowli requested a review from popzxc as a code owner October 10, 2023 12:28

slowli requested a review from RomanBrodetski October 10, 2023 12:28

RomanBrodetski removed their request for review October 10, 2023 13:09

slowli added 2 commits October 11, 2023 13:37

Make compile-time errors more intelligible

97fe5e3

...using `compile-fmt` crate

Update trybuild tests

c49c0bb

popzxc approved these changes Oct 18, 2023

View reviewed changes

slowli merged commit 90e5423 into main Oct 18, 2023
5 checks passed

slowli deleted the more-validations branch October 18, 2023 13:33