Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support info metrics #24

Merged
merged 11 commits into from
Apr 4, 2024
Merged

feat: Support info metrics #24

merged 11 commits into from
Apr 4, 2024

Conversation

slowli
Copy link
Collaborator

@slowli slowli commented Apr 3, 2024

What ❔

Adds support of the info metric type and adjacent helpers (e.g., units for labels and DurationAsSecs wrapper).

Why ❔

Info metrics is the idiomatic way to expose information not changed during the program runtime (version / git commit, component configs etc.).

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted and linted using cargo fmt and cargo clippy.

@slowli slowli requested a review from popzxc as a code owner April 3, 2024 11:32
@slowli slowli merged commit a5bb80c into main Apr 4, 2024
5 checks passed
@slowli slowli deleted the aov-pla-871-support-info-metrics-in-vise-library branch April 4, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

@montekki montekki Awaiting requested review from montekki

@RomanBrodetski RomanBrodetski Awaiting requested review from RomanBrodetski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slowli @popzxc