Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update formatters #167

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

chore: update formatters #167

wants to merge 12 commits into from

Conversation

itsacoyote
Copy link
Contributor

@itsacoyote itsacoyote commented Aug 16, 2024

Update eslintrc and prettier to work together with linting and formatting.

  • removed old eslintrc and use the new flat config eslint.config.js
    • version 9 of eslint will require use of the flat config file
  • removed use of @matterlabs/prettier-config for prettier, defined new prettier rules
    • it's a little out of date, will plan on improving this package later
  • added prettier import ordering rules that match existing import ordering rules that used to be in eslintrc
    • eslint is recommended for linting and prettier for formatting. Adding import ordering to prettier ensures the formatting will automatically handle the ordering of imports.
  • add editorconfig with rules. prettier inherits rules from it.
  • added vscode project settings and extensions to maintain consistency in developer environments
    • open to modifying these files before committing
  • modified the lint commands in package.json
    • streamlined the rules so that we have a single command to run in github workflow
    • added a format command
  • update tsconfig.json to cover tests folder for development
    • edit the build tsconfig.json so that it only covers src

@itsacoyote itsacoyote marked this pull request as ready for review August 19, 2024 20:36
@itsacoyote itsacoyote requested a review from a team as a code owner August 19, 2024 20:36
@itsacoyote
Copy link
Contributor Author

Need to merge #168 for CI tests to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant