Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement ProverContextConfig #10

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

robik75
Copy link
Member

@robik75 robik75 commented Sep 3, 2024

What ❔

This PR implements ProverContextConfig to enable configuration of ProverContext, among other things making it possible to limit the amount of allocated GPU memory.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and linted via cargo check.

@robik75 robik75 requested a review from EmilLuta September 3, 2024 13:03
@robik75 robik75 self-assigned this Sep 3, 2024
@robik75 robik75 force-pushed the rr-gpu-prover-ctx-limits branch from ca9e8f7 to 505dc31 Compare September 3, 2024 14:39
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some more tests for this functionality? AFAIU, we only changed the API calls. Can be done as a follow-up PR.

crates/shivini/src/static_allocator/device.rs Show resolved Hide resolved
@EmilLuta EmilLuta merged commit 0c6ba4b into main Sep 3, 2024
13 checks passed
@EmilLuta EmilLuta deleted the rr-gpu-prover-ctx-limits branch September 3, 2024 21:56
popzxc pushed a commit that referenced this pull request Sep 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.150.5](v0.150.4...v0.150.5)
(2024-09-04)


### Features

* **ci:** Introduce CI for automatic releases
([#11](#11))
([847059a](847059a))
* implement ProverContextConfig
([#10](#10))
([0c6ba4b](0c6ba4b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
robik75 added a commit that referenced this pull request Sep 4, 2024
# What ❔

This PR adds for new functionality in #10 .

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Code has been formatted via `cargo fmt` and linted via `cargo
fmt`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants