Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure build error fail preview job #322

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Conversation

MexicanAce
Copy link
Contributor

@MexicanAce MexicanAce commented Feb 11, 2025

Description

This enforces that unexpected errors during bun run build will not make their way into main and potentially break the docs

Evidence

BEFORE
image

AFTER
image

@MexicanAce MexicanAce requested a review from a team as a code owner February 11, 2025 14:07
Copy link

github-actions bot commented Feb 11, 2025

Visit the preview URL for this PR (updated for commit eccaaef):

https://zksync-docs-staging-5eb09--pr322-nmv-fix-build-errors-qndlm9cw.web.app

(expires Tue, 18 Feb 2025 16:03:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11

Copy link
Contributor

@uF4No uF4No left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MexicanAce MexicanAce merged commit ae3ace9 into main Feb 11, 2025
9 checks passed
@MexicanAce MexicanAce deleted the nmv/fix-build-errors-ci branch February 11, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants