fix: update function visibility in consistency_checker tests (#137)

* Add example: build_commit_tx_input_data_is_correct (fails)

* Abstract normal_checker_function test

* Abstract checker_processes_pre_boojum_batches

* Abstract checker_functions_after_snapshot_recovery test

* Abstract checker_functions_after_snapshot_recovery test

* Remove unnecessary auxiliar function

* Fix all the failing tests

* Use test_helpers module

* Remove ValidiumModeL1BatchCommitDataGenerator fix

* Add bytes pubdata with 0 value for the encoding (#136)

* Fix unnecessary pub

core/lib/zksync_core/src/consistency_checker/tests/mod.rs

@@ -178,7 +178,7 @@ fn extracting_commit_data_for_pre_boojum_batch() {
 }
 
 #[derive(Debug, Clone, Copy)]
-pub enum SaveAction<'a> {
+pub(crate) enum SaveAction<'a> {
     InsertBatch(&'a L1BatchWithMetadata),
     SaveMetadata(&'a L1BatchWithMetadata),
     InsertCommitTx(L1BatchNumber),
@@ -332,7 +332,7 @@ async fn checker_functions_after_snapshot_recovery(delay_batch_insertion: bool)
 }
 
 #[derive(Debug, Clone, Copy)]
-pub enum IncorrectDataKind {
+pub(crate) enum IncorrectDataKind {
     MissingStatus,
     MismatchedStatus,
     BogusCommitDataFormat,

core/lib/zksync_core/src/consistency_checker/tests/test_helpers.rs

@@ -7,7 +7,8 @@ use zksync_types::{web3::contract::Options, L2ChainId, ProtocolVersion};
 use super::*;
 use crate::genesis::{ensure_genesis_state, GenesisParams};
 
-pub fn build_commit_tx_input_data_is_correct(
+
+pub(crate) fn build_commit_tx_input_data_is_correct(
     l1_batch_commit_data_generator: Arc<dyn L1BatchCommitDataGenerator>,
 ) {
     let contract = zksync_contracts::zksync_contract();
@@ -35,7 +36,7 @@ pub fn build_commit_tx_input_data_is_correct(
     }
 }
 
-pub async fn normal_checker_function(
+pub(crate) async fn normal_checker_function(
     batches_per_transaction: usize,
     (mapper_name, save_actions_mapper): (&'static str, SaveActionMapper),
     l1_batch_commit_data_generator: Arc<dyn L1BatchCommitDataGenerator>,
@@ -104,7 +105,7 @@ pub async fn normal_checker_function(
     checker_task.await.unwrap().unwrap();
 }
 
-pub async fn checker_processes_pre_boojum_batches(
+pub(crate) async fn checker_processes_pre_boojum_batches(
     (mapper_name, save_actions_mapper): (&'static str, SaveActionMapper),
     l1_batch_commit_data_generator: Arc<dyn L1BatchCommitDataGenerator>,
 ) {
@@ -250,7 +251,7 @@ pub async fn checker_functions_after_snapshot_recovery(
     checker_task.await.unwrap().unwrap();
 }
 
-pub async fn checker_detects_incorrect_tx_data(
+pub(crate) async fn checker_detects_incorrect_tx_data(
     kind: IncorrectDataKind,
     snapshot_recovery: bool,
     l1_batch_commit_data_generator: Arc<dyn L1BatchCommitDataGenerator>,