Skip to content

Commit

Permalink
fix: Add exec to replace shell inside entrypoint with the actual bina…
Browse files Browse the repository at this point in the history
…ry (#134)

# What ❔

Replaces container shell with EN and local-env executables in
corresponding Docker images to eg. properly handle termination signals.

More details in original PR:
#76

Courtesy of https://github.com/voron
Thanks for the contribution, and sorry it took so long to review - we've
been busy with FOSS'ing our repos.

## Why ❔

#76 (comment)

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.

Co-authored-by: Alex Vorona <[email protected]>
Co-authored-by: Roman Brodetski <[email protected]>
  • Loading branch information
3 people authored Oct 6, 2023
1 parent f98c4fa commit f94b819
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docker/external-node/entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ set -e
# Prepare the database if it's not ready. No-op if the DB is prepared.
sqlx database setup
# Run the external node.
zksync_external_node
exec zksync_external_node
2 changes: 1 addition & 1 deletion docker/local-node/entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ fi
# start server
source /etc/env/dev.env
source /etc/env/.init.env
zksync_server
exec zksync_server

0 comments on commit f94b819

Please sign in to comment.