Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose job attempts metrics #114

Conversation

perekopskiy
Copy link
Contributor

@perekopskiy perekopskiy commented Sep 29, 2023

What ❔

Every component implementing JobProcessor now exposes two metrics:

  • <SERVICE_NAME>.job_attempts -- heatmaps in grafana will be added displaying this metric.
  • <SERVICE_ANME>.max_attempts_reached -- alert will fire when this metric is increased (alert rules not added yet).

Why ❔

Better monitoring and alerting

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

…job-retires from private at 218717c82d77aa2626d7f4a2c06e84b4ae33c87a
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (d8ab843) 31.58% compared to head (2ce1446) 31.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   31.58%   31.58%   -0.01%     
==========================================
  Files         477      477              
  Lines       25431    25455      +24     
==========================================
+ Hits         8033     8039       +6     
- Misses      17398    17416      +18     
Files Coverage Δ
core/bin/contract-verifier/src/verifier.rs 0.00% <ø> (ø)
core/lib/dal/src/fri_proof_compressor_dal.rs 0.00% <ø> (ø)
core/lib/dal/src/fri_prover_dal.rs 0.00% <ø> (ø)
core/lib/dal/src/fri_witness_generator_dal.rs 0.00% <ø> (ø)
core/lib/dal/src/prover_dal.rs 39.62% <100.00%> (+0.57%) ⬆️
core/lib/prometheus_exporter/src/lib.rs 62.74% <100.00%> (+0.74%) ⬆️
core/lib/types/src/proofs.rs 43.39% <ø> (ø)
prover/prover_fri/tests/basic_test.rs 0.00% <ø> (ø)
prover/witness_generator/tests/basic_test.rs 0.00% <ø> (ø)
core/lib/dal/src/witness_generator_dal.rs 49.76% <75.00%> (+0.47%) ⬆️
... and 5 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

perekopskiy and others added 2 commits October 2, 2023 12:58
…roverwitness-gen-job-retires-218717c82d77aa2626d7f4a2c06e84b4ae33c87a
@perekopskiy perekopskiy requested review from EmilLuta and akash-chandrakar and removed request for RomanBrodetski, Deniallugo and popzxc October 2, 2023 10:01
@perekopskiy perekopskiy closed this Nov 8, 2023
ilitteri added a commit that referenced this pull request Feb 23, 2024
* abstract setup mode method

* remove blank line

* add config mode in all init methods

* update log

* Fix some comments (#99)

* Fix eth_sender value

* Restore original config file and omit commented values

* Format

* abstract methods and constants

* remove async

* remove unnecessary async

* change constant value

* add cosntant

* fix: test new vars (#114)

* Update new variables between modes

* Format

* Fix toml format

* Fix remove line

* fix bug where dev.env is not overwritten

* Revert "fix bug where dev.env is not overwritten"

This reverts commit 051f173.

* fix bug in dev.env load

* Fix updateConfigFile

* Fix initialization

* Remove repeated constant definitions

* Remove internal enforced l1 gas price set

---------

Co-authored-by: toni-calvin <[email protected]>
Co-authored-by: Jordi <[email protected]>
Co-authored-by: Jordi <[email protected]>
Co-authored-by: Joaquin Carletti <[email protected]>
@perekopskiy perekopskiy deleted the mirror-perekopskiy-pla-344-add-alerting-on-proverwitness-gen-job-retires-218717c82d77aa2626d7f4a2c06e84b4ae33c87a branch April 16, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant