-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose job attempts metrics #114
Closed
perekopskiy
wants to merge
4
commits into
main
from
mirror-perekopskiy-pla-344-add-alerting-on-proverwitness-gen-job-retires-218717c82d77aa2626d7f4a2c06e84b4ae33c87a
Closed
feat: expose job attempts metrics #114
perekopskiy
wants to merge
4
commits into
main
from
mirror-perekopskiy-pla-344-add-alerting-on-proverwitness-gen-job-retires-218717c82d77aa2626d7f4a2c06e84b4ae33c87a
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…job-retires from private at 218717c82d77aa2626d7f4a2c06e84b4ae33c87a
perekopskiy
requested review from
RomanBrodetski,
Deniallugo,
popzxc and
a team
as code owners
September 29, 2023 14:01
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 31.58% 31.58% -0.01%
==========================================
Files 477 477
Lines 25431 25455 +24
==========================================
+ Hits 8033 8039 +6
- Misses 17398 17416 +18
☔ View full report in Codecov by Sentry. |
…roverwitness-gen-job-retires-218717c82d77aa2626d7f4a2c06e84b4ae33c87a
perekopskiy
requested review from
EmilLuta and
akash-chandrakar
and removed request for
RomanBrodetski,
Deniallugo and
popzxc
October 2, 2023 10:01
ilitteri
added a commit
that referenced
this pull request
Feb 23, 2024
* abstract setup mode method * remove blank line * add config mode in all init methods * update log * Fix some comments (#99) * Fix eth_sender value * Restore original config file and omit commented values * Format * abstract methods and constants * remove async * remove unnecessary async * change constant value * add cosntant * fix: test new vars (#114) * Update new variables between modes * Format * Fix toml format * Fix remove line * fix bug where dev.env is not overwritten * Revert "fix bug where dev.env is not overwritten" This reverts commit 051f173. * fix bug in dev.env load * Fix updateConfigFile * Fix initialization * Remove repeated constant definitions * Remove internal enforced l1 gas price set --------- Co-authored-by: toni-calvin <[email protected]> Co-authored-by: Jordi <[email protected]> Co-authored-by: Jordi <[email protected]> Co-authored-by: Joaquin Carletti <[email protected]>
perekopskiy
deleted the
mirror-perekopskiy-pla-344-add-alerting-on-proverwitness-gen-job-retires-218717c82d77aa2626d7f4a2c06e84b4ae33c87a
branch
April 16, 2024 09:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Every component implementing
JobProcessor
now exposes two metrics:<SERVICE_NAME>.job_attempts
-- heatmaps in grafana will be added displaying this metric.<SERVICE_ANME>.max_attempts_reached
-- alert will fire when this metric is increased (alert rules not added yet).Why ❔
Better monitoring and alerting
Checklist
zk fmt
andzk lint
.