Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update CODEOWNERS #118

Closed
wants to merge 3 commits into from
Closed

fix: Update CODEOWNERS #118

wants to merge 3 commits into from

Conversation

shahar4
Copy link
Collaborator

@shahar4 shahar4 commented Sep 29, 2023

What ❔

This PR removed core from being requested to review every PR in the repo.

Why ❔

Code owners is still WIP, but this state is not sensible.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@shahar4 shahar4 changed the title Update CODEOWNERS fix: Update CODEOWNERS Sep 29, 2023
yorik
yorik previously approved these changes Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d8ab843) 31.58% compared to head (ef31fad) 31.57%.

❗ Current head ef31fad differs from pull request most recent head 0fe2698. Consider uploading reports for the commit 0fe2698 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   31.58%   31.57%   -0.01%     
==========================================
  Files         477      477              
  Lines       25431    25431              
==========================================
- Hits         8033     8031       -2     
- Misses      17398    17400       +2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yorik yorik self-requested a review September 29, 2023 15:19
@Deniallugo
Copy link
Contributor

And who can approve PRs?

@shahar4 shahar4 requested a review from a team as a code owner September 29, 2023 16:44
@shahar4 shahar4 closed this Sep 29, 2023
@shahar4 shahar4 deleted the sk-codeowners branch September 29, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants