Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tests): Gas oracle tests #1567

Merged
merged 67 commits into from
Apr 9, 2024
Merged

feat(tests): Gas oracle tests #1567

merged 67 commits into from
Apr 9, 2024

Conversation

fkrause98
Copy link
Contributor

What ❔

As commented here,
we need a way of testing the new gas-oracle components, plus a way to run them in the CI.

Why ❔

To ensure the new components working properly

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

jrchatruc and others added 30 commits February 1, 2024 17:02
@jrchatruc
[WIP] Gas oracle to convert native token price
a15cd2c
@jrchatruc
zk fmt
dcd2721
@jrchatruc
Connect with fetcher with config data to get the host and poll interval
c8626a7
@jrchatruc
Remove unused fields
06ec84d
@juan518munoz
add erc20 fetcher to gas adjuster
5c6b647
fix env vars names, remove unused variable
9a055f2
remove cast to u64
a16252b
remove unused field from ZkSyncStateKeeper
4fe5b7a
@jrchatruc
Merge remote-tracking branch 'upstream/kl-factory' into gas-oracle
b7cbd70
@jrchatruc
Merge remote-tracking branch 'upstream/kl-factory' into gas-oracle
c3a8d80
@jrchatruc
Use = &mut instead of ref mut
5de1233
@jrchatruc
Fetch the conversion rate on Fetcher initialization to avoid incorrec…
773ff7a 
…t values on server startup
@jrchatruc
Merge remote-tracking branch 'upstream/kl-factory' into gas-oracle
3cb3e5c
@jrchatruc
Add http client as a field to the native erc20 fetcher
fd3e7d2
@jrchatruc
Rename NativeErc20 stuff to be NativeToken instead
6838588
@jrchatruc
Merge remote-tracking branch 'upstream/lambdaclass_gas_oracle' into c…
2ebe86b 
…ache-http-client
@juan518munoz
initial commit
67286bc
@juan518munoz
remove comment
08e8b5a
@juan518munoz
remove needless variable
7ca95b8
@juan518munoz
initial commit
0315e46
@juan518munoz
initial commit
c79dccb
@juan518munoz
rmv unwrap
b6367ad
@juan518munoz
improve err handling
252312a
@jrchatruc
Merge pull request matter-labs#1263 from lambdaclass/cache-http-client
83dd481 
fix(Gas Oracle): Add http client as a field to the native erc20 fetcher
@jrchatruc
Merge pull request matter-labs#1272 from lambdaclass/gas-oracle-noop-…
e91c27c 
…conversion-rate-fetcher

feat(Gas Oracle): Make the Erc20 Fetcher mandatory and have a no-op implementation
@juan518munoz
Merge branch 'lambdaclass_gas_oracle' into gas-oracle-change-err-type
7214d5e
store native token address in fetcher config, use it in the conversio…
7b33934 
…n rate endpoint subdir
add mission EOF
e4fb1c4
remove print
6d114f3
@jrchatruc
Merge pull request matter-labs#1281 from lambdaclass/gas-oracle-chang…
3d4addd 
…e-err-type

feat(Gas Oracle): Use normal anyhow::Error for the `NativeErc20Fetcher`
juan518munoz and others added 26 commits March 4, 2024 13:47
@juan518munoz
merge lambdaclass_gas_oracle
1154e54
@jrchatruc
Merge pull request matter-labs#1282 from lambdaclass/gas-oracle-imprv…
79a8eb2 
…-fetcher-err

feat(Gas Oracle): Improve Fetcher Error Handling
@juan518munoz
Merge branch 'lambdaclass_gas_oracle' into conversion_rate_component
984e052
@juan518munoz
fix up code
dd11e4a
@jrchatruc
[WIP] Remove native token fetcher singleton
1a20f2a
@jrchatruc
Fix compilation (add missing await)
3103dca
@jrchatruc
Merge remote-tracking branch 'upstream/lambdaclass_gas_oracle' into r…
0e2f572 
…emove-token-fetcher-singleton
@juan518munoz
fix stop handle for converstion rate api
cf5f2ff
@juan518munoz
add logging for conversion rate
46b6ef4
@jrchatruc
Remove unnecessary alert_spawned boolean
6e0c812
@jrchatruc
Revert "Remove unnecessary alert_spawned boolean"
13cf343 
This reverts commit 6e0c812.
@jrchatruc
Use a mutex for the errorreporter
fbf66b1
@jrchatruc
Revert changes to .init.env
a19be60
@juan518munoz
rmv flask app, rename component & refactor func
d99e9bf
@juan518munoz
rename module
8d37924
@jrchatruc
Merge pull request matter-labs#1319 from lambdaclass/conversion_rate_…
feaf132 
…component

feat(Gas Oracle): Conversion rate component
@jrchatruc
Merge remote-tracking branch 'upstream/lambdaclass_gas_oracle' into r…
3fff7d9 
…emove-token-fetcher-singleton
@jrchatruc
Merge pull request matter-labs#1360 from lambdaclass/remove-token-fet…
ba7762c 
…cher-singleton

feat(Gas Oracle): Remove Fetcher singleton
@jrchatruc
Merge branch 'kl-factory' into lambdaclass_gas_oracle
d81aef0
@juan518munoz
zk fmt
5680df8
@juan518munoz
Merge remote-tracking branch 'matter-labs/kl-factory' into gas-oracle
47c444f
@juan518munoz
rename native token to base token
b520744
@juan518munoz
fix env load
29289c9
add gas oracle documentation
7c8ec45
fmt
2a7761d
@fkrause98
Merge branch 'kl-factory' into gas-oracle
55ae89f
@fkrause98 fkrause98 mentioned this pull request Apr 3, 2024
Merged
6 tasks
@lferrigno lferrigno merged commit bac7a4c into matter-labs:kl-factory Apr 9, 2024
25 of 92 checks passed
@lferrigno lferrigno deleted the gas-oracle-tests branch April 9, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fkrause98 @lferrigno @jrchatruc @juan518munoz