Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boojum): Don't pass aggregation_results as recursive aggregation inputs #157

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Oct 4, 2023

What ❔

  • We were passing incorrect argument to the prover

Why ❔

  • to make prover work, the original problem was a simple bug/typo.

@mm-zk mm-zk requested a review from a team as a code owner October 4, 2023 18:03
@mm-zk mm-zk requested review from gluk64, ly0va and a team and removed request for a team October 4, 2023 18:03
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d4f292b) 32.17% compared to head (30a7913) 32.16%.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           boojum-integration     #157      +/-   ##
======================================================
- Coverage               32.17%   32.16%   -0.02%     
======================================================
  Files                     482      482              
  Lines                   25923    25929       +6     
======================================================
- Hits                     8342     8340       -2     
- Misses                  17581    17589       +8     
Files Coverage Δ
core/lib/types/src/aggregated_operations.rs 48.88% <0.00%> (+2.08%) ⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mm-zk mm-zk merged commit 1625ec2 into boojum-integration Oct 4, 2023
17 of 24 checks passed
@mm-zk mm-zk deleted the mmzk_1004_fix_agg_results branch August 5, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants