Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prover): switch compression to fflonk #2766

Draft
wants to merge 59 commits into
base: main
Choose a base branch
from
Draft

feat(prover): switch compression to fflonk #2766

wants to merge 59 commits into from

Conversation

itegulov
Copy link
Contributor

@itegulov itegulov commented Aug 29, 2024 •
edited by Artemka374
Loading

What ❔

This PR as of commit d1178f7 should work as is and I suggest to whoever picks this work up to try and run this on a g2-16 machine on GCP to confirm that everything works as intended.

TODO:

  1. [BLOCKED] We can't enable using of PLONK proofs in eth sender currently, because we have type conflicts because of branch dependencies. Should be re-enabled after dependencies are merged and tested with dual contract .
  2. [BLOCKED] Test this PR e2e with contracts that are updated to support FFLONK (they were not available during my work but hopefully are by the time you are reading this). I expect there to be some friction in serialization format expected by EVM. I took code suggested by Sait but it is completely untested.
  3. [BLOCKED] Add workflow to generate VKs and setup keys for FFLONK compressor
  4. Rework Keystore and Setup Keys generation to also generate FFLONK setup keys

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

Artemka374 and others added 30 commits October 18, 2024 14:57
@Artemka374
fix build
df58203
@Artemka374
fix build
25a8d2e
@Artemka374
Merge branch 'refs/heads/main' into daniyar/fflonk
22fff07 
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	prover/Cargo.lock
#	prover/Cargo.toml
@Artemka374
fix build
59faf9b
@Artemka374
change proof struct
7dd3ba3
@Artemka374
add keystore stub
d3dbaf5
@Artemka374
fix build
b45a6da
@Artemka374
add fflonk feature to zkstack
05286b4
@Artemka374
Merge remote-tracking branch 'origin/daniyar/fflonk' into daniyar/fflonk
b3995d4 
# Conflicts:
#	prover/crates/lib/keystore/src/keystore.rs
@Artemka374
adjust eth_sender to work with new proofs(plonk is disabled for now)
2d7572c
@Artemka374
fix imports in compressor
924bdeb
@Artemka374
make some deps optional
f2b43e7
@Artemka374
fix lint
3c2fa71
@Artemka374
fix a few other things
5d7ae04
@Artemka374
fix build
b2594e7
@Artemka374
add compressor keys to zkstack_cli
837ea8b
@Artemka374
Merge branch 'refs/heads/main' into daniyar/fflonk
8544d16
@Artemka374
fix downloading compressor keys
0171eed
@Artemka374
fmt, adjust vks a bit
90be08b
@Artemka374
merge main
f02c6d2
@Artemka374
Merge branch 'refs/heads/main' into daniyar/fflonk
e76ed7f 
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	prover/Cargo.lock
#	prover/Cargo.toml
@Artemka374
Merge remote-tracking branch 'origin/daniyar/fflonk' into daniyar/fflonk
efed1ac 
# Conflicts:
#	Cargo.lock
#	prover/Cargo.lock
@Artemka374
fix dependencies, continue reworking keystore
dee361e
@Artemka374
bump dependencies
e45f0e8
@Artemka374
Merge branch 'refs/heads/main' into daniyar/fflonk
019e33d 
# Conflicts:
#	Cargo.lock
@Artemka374
fix cargo.lock
3de4496
@Artemka374
update cargo toml
4acdd70
@Artemka374
enable plonk in eth sender
3cdcae8
@Artemka374
adjust compressor and vk generator to new crypto deps
dc78371
@Artemka374
Merge branch 'main' into daniyar/fflonk
0a37276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itegulov @Artemka374