-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(vm): Improve instruction-counting VM benchmark #3105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observations so far:
So, the number of instructions per second is roughly the same for all benches and it has the expected order of magnitude 🙃 Not so good observations:
|
slowli
changed the title
test: Improve instruction-counting VM benchmark
test(vm): Improve instruction-counting VM benchmark
Oct 16, 2024
slowli
force-pushed
the
aov-pla-1049-improve-instructions-vm-benchmark
branch
from
October 16, 2024 12:57
d279c32
to
4dc0f13
Compare
slowli
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet,
otani88,
iluwaa and
joonazan
October 16, 2024 13:56
joonazan
reviewed
Oct 16, 2024
joonazan
reviewed
Oct 16, 2024
joonazan
reviewed
Oct 18, 2024
joonazan
reviewed
Oct 18, 2024
joonazan
reviewed
Oct 18, 2024
joonazan
reviewed
Oct 18, 2024
joonazan
reviewed
Oct 18, 2024
joonazan
reviewed
Oct 18, 2024
joonazan
reviewed
Oct 18, 2024
joonazan
previously approved these changes
Oct 28, 2024
slowli
force-pushed
the
aov-pla-1049-improve-instructions-vm-benchmark
branch
from
October 28, 2024 15:20
66df17c
to
d6aff26
Compare
artmakh
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Replaces
iai
with an alternative; brushes up instruction counting in general.Why ❔
iai
) is unmaintained.Checklist
zkstack dev fmt
andzkstack dev lint
.