Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Conditional to build contracts in new CI #3106

Merged
merged 3 commits into from
Oct 16, 2024
Merged

fix(ci): Conditional to build contracts in new CI #3106

merged 3 commits into from
Oct 16, 2024

Conversation

artmakh
Copy link
Contributor

@artmakh artmakh commented Oct 16, 2024

What ❔

Do not build contracts if not needed in new CI

Why ❔

Speed up CI

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@artmakh artmakh requested a review from a team as a code owner October 16, 2024 10:44
@artmakh artmakh added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024
@artmakh artmakh added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024
@Deniallugo Deniallugo added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024
@artmakh artmakh added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 8790240 Oct 16, 2024
63 of 82 checks passed
@artmakh artmakh deleted the ciimprovements branch October 16, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorik yorik yorik approved these changes

@Deniallugo Deniallugo Deniallugo approved these changes

@otani88 otani88 otani88 approved these changes

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@iluwaa iluwaa Awaiting requested review from iluwaa iluwaa is a code owner automatically assigned from matter-labs/devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artmakh @yorik @Deniallugo @otani88