Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(vm): Deduplicate multivm tests #3109

Merged
merged 19 commits into from
Oct 18, 2024
Merged

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Oct 16, 2024

What ❔

Deduplicates unit tests in the multivm crate by retaining a single generic copy parameterized by a VM (with test-specific functionality encapsulated in a new TestedVm trait).

Why ❔

2 copies of almost every test is difficult to maintain.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@slowli
Copy link
Contributor Author

slowli commented Oct 16, 2024

The change diff is smaller than it looks; it mostly consists of moving stuff around. I've needed to massage a couple of tests so that they work in the same way for both legacy and fast VMs, but I've tried to not reduce the test scope whenever possible.

@slowli slowli marked this pull request as ready for review October 16, 2024 12:52
joonazan
joonazan previously approved these changes Oct 17, 2024
@slowli slowli enabled auto-merge October 18, 2024 06:50
@slowli slowli added this pull request to the merge queue Oct 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
@slowli slowli added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit c488c55 Oct 18, 2024
33 checks passed
@slowli slowli deleted the aov-pla-1050-deduplicate-multivm-tests branch October 18, 2024 11:55
@slowli slowli mentioned this pull request Oct 21, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants