-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(vm): Deduplicate multivm
tests
#3109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change diff is smaller than it looks; it mostly consists of moving stuff around. I've needed to massage a couple of tests so that they work in the same way for both legacy and fast VMs, but I've tried to not reduce the test scope whenever possible. |
slowli
requested review from
RomanBrodetski,
Deniallugo,
joonazan and
perekopskiy
October 16, 2024 12:52
joonazan
reviewed
Oct 16, 2024
joonazan
reviewed
Oct 17, 2024
joonazan
previously approved these changes
Oct 17, 2024
joonazan
approved these changes
Oct 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Deduplicates unit tests in the
multivm
crate by retaining a single generic copy parameterized by a VM (with test-specific functionality encapsulated in a newTestedVm
trait).Why ❔
2 copies of almost every test is difficult to maintain.
Checklist
zkstack dev fmt
andzkstack dev lint
.