test(vm): Run `multivm` tests with shadowing #3137

slowli · 2024-10-21T10:11:52Z

What ❔

Runs shared unit tests in the multivm crate for the shadowed VM.

Allows to cheaply check VM divergences.

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.
Code has been formatted via zkstack dev fmt and zkstack dev lint.

core/lib/multivm/src/versions/testonly/get_used_contracts.rs

slowli added 5 commits October 21, 2024 10:30

Move shadow module

23956af

Expose custom getters for ShadowVm

fb35e67

Add multivm tests with ShadowVm

7d716f0

Rework TestedVm::known_bytecode_hashes()

a989521

Mention shadow tests in readme

8c2092d

slowli marked this pull request as ready for review October 21, 2024 11:26

slowli requested review from joonazan, perekopskiy and Deniallugo October 21, 2024 11:26

perekopskiy previously approved these changes Oct 23, 2024

View reviewed changes

core/lib/multivm/src/versions/testonly/get_used_contracts.rs Outdated Show resolved Hide resolved

Remove dbg! artifact

cbf4451

slowli dismissed perekopskiy’s stale review via cbf4451 October 23, 2024 12:00

joonazan approved these changes Oct 23, 2024

View reviewed changes

slowli added this pull request to the merge queue Oct 23, 2024

Merged via the queue into main with commit 84986f4 Oct 23, 2024
33 checks passed

slowli deleted the aov-pla-1053-run-multivm-tests-on-shadow-vm branch October 23, 2024 15:25